[PATCH] MongoDB DLR support

Alexander Malysh amalysh at kannel.org
Mon Apr 4 19:12:59 CEST 2011


Hi,

please use reply all...

Am 04.04.2011 um 12:18 schrieb Roman Shterenzon:

> Hi Alexander,
> 
> 1. I used the standard MIT license, which is compatible with most other, including Kannel, licenses. Should I copy the license clause from one of kannel files and just change the copyright line? As copyright is applied to each file separately, it doesn't make sense to say that "Portions of this software are based upon software originally written at WapIT Ltd.", etc.

yes, please copy copyright from any existing file

> 2. Yes, it's on my TODO list. There were some problems with it, so I disabled it for meanwhile.

ok

> 3. These functions don't make sense, as there's no "SQL statement" in MongoDB world. I can, of course, do an ugly casting from struct bson just to make it adhere to this form, but I see no reason of doing so. I would, of course, if mongodb_select/mongodb_update were used in other places.

they make maybe now no sense but later if someone want to use MongoDB pool in kannel he don't need to implement same things again...

> 
> Thanks,
> --Roman
> 
> From: Alexander Malysh <amalysh at kannel.org>
> To: Roman Shterenzon <romanbsd at yahoo.com>
> Cc: "devel at kannel.org" <devel at kannel.org>
> Sent: Monday, April 4, 2011 12:59 PM
> Subject: Re: [PATCH] MongoDB DLR support
> 
> Hi Roman,
> 
> after quick review:
> 1) please fix copyright, see other kannel files
> 2) please implement authentication for mongo DB if supported or remove it
> 3) please implement mongodb_select/mongodb_update and use it in dlr_mongodb.c
>     These functions used as abstraction layer so that we don't need to pass mondodb specific
>      things to dlr_mongodb.c except specific SQL.
> 
> Thanks,
> Alexander Malysh
> 
> Am 04.04.2011 um 11:33 schrieb Roman Shterenzon:
> 
>> Good day,
>> 
>> I've added support for using MongoDB document database for DLR storage.
>> I wouldn't call this production grade, but rather tag it as a "works for me" or "experimental".
>> 
>> The code is hosted on github:
>> https://github.com/romanbsd/kannel-mongodb
>> 
>> 
>> Your feedback is appreciated!
>> 
>> --Roman<kannel-mongodb.patch>
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.kannel.org/pipermail/devel/attachments/20110404/c3f79234/attachment.html>


More information about the devel mailing list