[PATCH] smsc_at2.c error string

Vincent CHAVANIS v.chavanis at telemaque.fr
Wed Jun 17 14:26:52 CEST 2009


This one should fit.

Vincent.

Alexander Malysh a écrit :
> sorry, but still the same:
> 
> +    case 0:
> +      /*
> +       * Default the code to 0 then when you extract the value from the
> +       * modem response message and no code is found, 0 will result.
> +       */
> +      return "Modem returned ERROR but no error code - possibly 
> unsupported or invalid command?";
> 
> indents are 4 spaces instead of 2.
> 
> Thanks,
> Alex
> 
> Am 17.06.2009 um 13:24 schrieb Vincent CHAVANIS:
> 
>> yep, you're right.
>>
>> new file attached.
>> without blank comments, and text cleaned.
>>
>> Vincent.
>>
>> Alexander Malysh a écrit :
>>> Hi Vincent,
>>> some comments:
>>> +            error(0, "AT2[%s]: [%d/%ld] Initialization of device 
>>> failed.", octstr_get_cstr(privdata->name),
>>> +                     error_count, privdata->max_error_count);
>>> this is not very informative for kannel user. Please write out 
>>> something like Init failed errors X from max errors X.
>>> please kill comments like this:
>>> +      /*
>>> +       */
>>> please fix indentation, we use 4 spaces...
>>> Thanks,
>>> Alex
>>> Am 17.06.2009 um 12:56 schrieb Vincent CHAVANIS:
>>>>
>>>> From an old thread 
>>>> (http://www.mail-archive.com/users@kannel.org/msg07693.html)
>>>> Alex moved the at2_error_string into smsc_at.c
>>>>
>>>> 2004-09-18 Alexander Malysh <amalysh at kannel.org>
>>>>   * gw/smsc/smsc_at.c: added new function 'at2_error_string' and 
>>>> teached
>>>>     smsc_at to use it.
>>>>
>>>> But some error codes are missing.
>>>> 1472:2009-06-16 16:00:59.0442 [2255] [8] ERROR: AT2[WAVECOM]: 
>>>> Generic error: +CME ERROR: 515
>>>> 2710:2009-06-16 23:35:40.0142 [2255] [8] ERROR: AT2[WAVECOM]: CMS 
>>>> ERROR: +CMS ERROR: 513
>>>> 2711:2009-06-16 23:35:40.0142 [2255] [8] ERROR: AT2[WAVECOM]: CMS 
>>>> ERROR: Error number unknown. Ask google and add it. (513)
>>>>
>>>> Each code is more or less detailled on comments
>>>> I think this should be left as it as there are no documentation on it.
>>>>
>>>> This patch also prints the counter before the reset-string.
>>>>
>>>> Vincent.
>>>>
>> <smsc_at2_error_string_patch_v2.txt>
> 
> 
> 

-- 
Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR)
Service Technique/Reseau - NOC
Direction du Developpement xMS+
http://www.telemaque.fr/
v.chavanis at telemaque.fr
Tel : +33 4 92 90 99 84 (fax 9142)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: smsc_at2_error_string_patch_v3.txt
URL: <http://www.kannel.org/pipermail/devel/attachments/20090617/205fb3b5/attachment.txt>


More information about the devel mailing list